Changeset 100

Timestamp:

03/24/2009 07:54:48 PM (3 years ago)

Author:

ofer

Message:

Fixed problematic HTML which prevented our option screen from showing correctly on IE

File:

• trunk/WordPress/plugin/transposh/transposh_admin.php (modified) (21 diffs)

trunk/WordPress/plugin/transposh/transposh_admin.php

@@ -20 +20 @@
  * Provide the admin page for configuring the translation options. eg.  what languages ?
  * who is allowed to translate ?
- *
  */
 
@@ -26 +25 @@
 require_once("constants.php");
 
-
 /*
  * Add transposh to the admin menu.
- *
  */
 function transposh_admin_menu()
@@ -36 +33 @@
 }
 
-
 /*
  * Create the admin page.
- *
  */
 function transposh_admin_page()
@@ -73 +68 @@
 /*
  * Insert supported languages section in admin page
- *
  */
 function insert_supported_langs()
@@ -79 +73 @@
         global $languages, $plugin_url;
 
-        echo '
-    <script type="text/javascript" >
-        function chbx_change(lang)
-        {
-            var view = lang + "_view";
-            if(document.getElementById(view).checked)
-            {
-                var edit = lang + "_edit";
-                document.getElementById(edit).checked = true;
-            }
-
-        }
-    </script>
-
-    <table>
-    <tr>';
-
+        echo '<script type="text/javascript">'.
+        'function chbx_change(lang)'.
+        '{'.
+            'var view = lang + "_view";'.
+            'if(document.getElementById(view).checked)'.
+            '{'.
+               'var edit = lang + "_edit";'.
+                'document.getElementById(edit).checked = true;'.
+            '}'.
+        '}'.
+    '</script>';
+        echo '<table><tr>';
 
         $columns = 2;
@@ -101 +90 @@
         for($hdr=0; $hdr < $columns; $hdr++)
         {
-                echo '<th>Language</th><th>Viewable</th><th>Translatable</th>
-              <th>Default</th><th style="padding-right: 80px"></th>';
+                echo '<th>Language</th><th>Viewable</th><th>Translatable</th>'.
+             '<th>Default</th><th style="padding-right: 80px"></th>';
         }
 
@@ -112 +101 @@
                 if($i % $columns == 0)
                 {
-                        echo '</tr>';
+                        echo '<tr>';
                 }
                 echo "\n";
@@ -118 +107 @@
                 $i++;
 
-                echo "<td><img src=\"$plugin_url/flags/$flag.png\"/>&nbsp;$language</td>";
+                echo "<td><img src=\"$plugin_url/flags/$flag.png\" alt=\"\"/>&nbsp;$language</td>";
                 echo '<td align="center">  <input type="checkbox" id="' . $code .'_view" name="' .
-                $code . '_view" onChange="chbx_change(\'' . $code . '\')"' . is_viewable($code) . '/></td>';
+                $code . '_view" onChange="chbx_change(\'' . $code . '\')" ' . is_viewable($code) . '/></td>';
                 echo "\n";
                 echo '<td align="center">  <input type="checkbox" id="' . $code . '_edit" name="' .
                 $code . '_edit" ' . is_editable($code). '/></td>';
                 echo "\n";
-                echo "<td align=\"center\"><input type=\"radio\" name=\"default_lang\" value=\"$code\"" .
-                is_default_lang($code). "/> </td>";
+                echo "<td align=\"center\"><input type=\"radio\" name=\"default_lang\" value=\"$code\" " .
+                is_default_lang($code). "/></td>";
 
                 if($i % $columns == 0)
@@ -134 +123 @@
                 else
                 {
-                        echo "<td><style padding-right: 60px></style></td>";
+                        echo "<td style=\"padding-right: 60px\"></td>";
                 }
                 echo "\n";
@@ -153 +142 @@
         if(strstr($langs, $code))
         {
-                return "checked";
+                return 'checked="checked"';
         }
 
@@ -168 +157 @@
         if(strstr($langs, $code))
         {
-                return "checked";
+                return 'checked="checked"';
         }
 
@@ -191 +180 @@
         if($default ==  $code)
         {
-                return "checked";
+                return 'checked="checked"';
         }
 
@@ -199 +188 @@
 /*
  * Insert permissiions section in the admin page
- *
  */
 function insert_permissions()
@@ -209 +197 @@
         {
                 echo '<input type="checkbox" value="1" name="' . $role_name . '" ' . can_translate($role_name) .
-             '" />' . $role_name . '&nbsp&nbsp&nbsp</input>';
+             '/>' . $role_name . '&nbsp;&nbsp;&nbsp;';
         }
 
         //Add our own custom role
-        echo '<input type="checkbox" value="1" name="anonymous"'     .
-        can_translate('anonymous') . '" /> Anonymous</input>';
+        echo '<input type="checkbox" value="1" name="anonymous" '.
+        can_translate('anonymous') . '/> Anonymous';
 }
 
@@ -227 +215 @@
         if(get_option(ENABLE_PERMALINKS_REWRITE))
         {
-                $checked = 'checked';
-        }
-
-        echo '<input type="checkbox" value="1" name="enable_permalinks"'. $checked . '"/>'.
+                $checked = 'checked="checked"';
+        }
+
+        echo '<input type="checkbox" value="1" name="enable_permalinks" '. $checked . '/>'.
                  'Rewrite URLs to be search engine friendly, '.
                  'e.g.  (http://wordpress.org/<strong> en</strong>). '.
-         'Requires that permalinks will be enabled.'.
-         '</input>';
+         'Requires that permalinks will be enabled.';
 }
 
@@ -240 +227 @@
  * Insert the option to enable/disable automatic translation.
  * Enabled by default.
- *
  */
 function insert_auto_translate_option()
@@ -247 +233 @@
         if(get_option(ENABLE_AUTO_TRANSLATE,1))
         {
-                $checked = 'checked';
-        }
-
-        echo '<input type="checkbox" value="1" name="enable_autotranslate"'.$checked.'"/>'.
-             'Allow automatic translation of pages (currently using Google Translate).'.
-             '</input>';
+                $checked = 'checked="checked"';
+        }
+
+        echo '<input type="checkbox" value="1" name="enable_autotranslate" '.$checked.'/>'.
+             'Allow automatic translation of pages (currently using Google Translate)';
 }
 
@@ -267 +252 @@
                 if(isset($role) && $role->has_cap(TRANSLATOR))
                 {
-                        return 'checked';
+                        return 'checked="checked"';
                 }
         }
@@ -275 +260 @@
                 if($allow_anonymous == "1")
                 {
-                        return 'checked';
+                        return 'checked="checked"';
                 }
         }
@@ -284 +269 @@
 /*
  * Handle newly posted admin options.
- *
  */
 function update_admin_options()
@@ -351 +335 @@
         }
 
-        echo '<div id="message"class="updated fade">';
-        echo ('<p> Changes saved</p>');
+        echo '<div id="message" class="updated fade">';
+        echo '<p>Changes saved</p>';
         echo '</div>';
 }